Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calibration args from generate.py #1258

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

vayuda
Copy link
Collaborator

@vayuda vayuda commented Nov 10, 2024

Proper calibration for awq is not necessary for performance evaluation and adds bloat to the list of command line arguments. Removed two calibration related arguments.

Tested using:
python3 generate.py -q awq-uint4-32-hqq --compile --checkpoint_path ../../../scripts/checkpoints/meta-llama/llama-2-7b-chat-hf/model.pth

after downloading llama2-7b-chat-hf and performing checkpoint conversion

@vayuda vayuda requested a review from HDCharles November 10, 2024 00:46
Copy link

pytorch-bot bot commented Nov 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1258

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 107e7e4 with merge base 75f52ae (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2024
@vayuda vayuda added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Nov 10, 2024
@vayuda vayuda merged commit 129316d into pytorch:main Nov 20, 2024
18 of 20 checks passed
sunjiweiswift pushed a commit to sunjiweiswift/ao that referenced this pull request Nov 25, 2024
Removed calibration args from generate.py script because quantization speedup analysis does not require "real" calibration
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants