Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrink hadamard matrices #1051

Merged
merged 1 commit into from
Oct 11, 2024
Merged

shrink hadamard matrices #1051

merged 1 commit into from
Oct 11, 2024

Conversation

HDCharles
Copy link
Contributor

Summary:

this isn't intended to be human readable anyway so shoving them all into the same line seems fine

this reduces lines of code in our repo by about half

Test Plan:

python test/prototype/test_spinquant.py

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

this isn't intended to be human readable anyway so shoving them all into
the same line seems fine

Test Plan:

python test/prototype/test_spinquant.py

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Oct 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1051

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f62709e with merge base 10601b3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
@HDCharles HDCharles requested a review from msaroufim October 10, 2024 21:39
@msaroufim msaroufim merged commit ec860a1 into main Oct 11, 2024
17 checks passed
@msaroufim msaroufim deleted the 049_fix_had branch October 11, 2024 00:45
jainapurva pushed a commit that referenced this pull request Oct 15, 2024
Summary:

this isn't intended to be human readable anyway so shoving them all into
the same line seems fine

Test Plan:

python test/prototype/test_spinquant.py

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants