Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-87506: Document that json.load*() can raise UnicodeDecodeError #127355

Merged
merged 6 commits into from
Jan 8, 2025
Merged

gh-87506: Document that json.load*() can raise UnicodeDecodeError #127355

merged 6 commits into from
Jan 8, 2025

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Nov 28, 2024 •
edited
Loading

gh-87506: Improve the documentation for json.load() and json.loads()

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 28, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 28, 2024
Closed
@srinivasreddy
Copy link
Contributor Author

Since @serhiy-storchaka moved this into JSON issues, I am raising this PR.
If @rhettinger still feel that it is okay to forgo this documentation update since we cannot,(should not) comprehensively document every exception. And in that case we can successfully close the issue.

@skirpichev skirpichev changed the title gh-87505: Improve the documentation for json.load() and json.loads() gh-87506: Improve the documentation for json.load() and json.loads() Nov 28, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 28, 2024
Closed
@rhettinger rhettinger removed their request for review November 29, 2024 03:39
@erlend-aasland erlend-aasland self-requested a review January 4, 2025 17:42
@erlend-aasland erlend-aasland self-assigned this Jan 4, 2025
@erlend-aasland

This comment was marked as resolved.

Sign in to view
@erlend-aasland
Copy link
Contributor

@srinivasreddy, please pull in main and resolve the conflicts.

@erlend-aasland erlend-aasland linked an issue Jan 8, 2025 that may be closed by this pull request
json.load() can raise UnicodeDecodeError, but this is not documented #87506
Closed
erlend-aasland
erlend-aasland approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erlend-aasland erlend-aasland changed the title gh-87506: Improve the documentation for json.load() and json.loads() gh-87506: Document that json.load*() can reaise UnicodeDecodeError Jan 8, 2025
@erlend-aasland erlend-aasland changed the title gh-87506: Document that json.load*() can reaise UnicodeDecodeError gh-87506: Document that json.load*() can raise UnicodeDecodeError Jan 8, 2025
@erlend-aasland erlend-aasland enabled auto-merge (squash) January 8, 2025 07:32
@erlend-aasland erlend-aasland enabled auto-merge (squash) January 8, 2025 07:33
@erlend-aasland erlend-aasland merged commit 15372d0 into python:main Jan 8, 2025
29 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy @erlend-aasland @miss-islington
pythongh-87506: Document that json.load*() can raise UnicodeDecodeErr…
5e4a237 
…or (pythonGH-127355)

(cherry picked from commit 15372d0)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128607 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy @erlend-aasland @miss-islington
pythongh-87506: Document that json.load*() can raise UnicodeDecodeErr…
4b382f6 
…or (pythonGH-127355)

(cherry picked from commit 15372d0)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128608 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 8, 2025
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 8, 2025
@erlend-aasland
pythongh-87506: Amend json.loads() post PR python#127355
7fd9e7d
erlend-aasland added a commit that referenced this pull request Jan 8, 2025
@erlend-aasland
gh-87506: Amend json.loads() post PR #127355 (#128609)
cdfb8bc
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@erlend-aasland @miss-islington
pythongh-87506: Amend json.loads() post PR pythonGH-127355 (pythonGH-…
0d3912a 
…128609)

(cherry picked from commit cdfb8bc)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@erlend-aasland @miss-islington
pythongh-87506: Amend json.loads() post PR pythonGH-127355 (pythonGH-…
f2cce84 
…128609)

(cherry picked from commit cdfb8bc)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy @erlend-aasland
pythongh-87506: Document that json.load*() can raise UnicodeDecodeErr…
4d8ab83 
…or (pythonGH-127355)

(cherry picked from commit 15372d0)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy @erlend-aasland
[3.13] pythongh-87506: Document that json.load*() can raise UnicodeDe…
1a94188 
…codeError (pythonGH-127355)

(cherry picked from commit 15372d0)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
erlend-aasland added a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy @erlend-aasland
[3.12] pythongh-87506: Document that json.load*() can raise UnicodeDe…
27a1cda 
…codeError (pythonGH-127355)

(cherry picked from commit 15372d0)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jan 8, 2025
@miss-islington @srinivasreddy @erlend-aasland
[3.13] gh-87506: Document that json.load*() can raise UnicodeDecodeEr…
0cd6036 
…ror (GH-127355) (#128607)

(cherry picked from commit 15372d0)
(cherry picked from commit cdfb8bc)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jan 8, 2025
@miss-islington @srinivasreddy @erlend-aasland
[3.12] gh-87506: Document that json.load*() can raise UnicodeDecodeEr…
e903b8a 
…ror (GH-127355) (#128608)

(cherry picked from commit 15372d0)
(cherry picked from commit cdfb8bc)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Co-authored-by: Erlend Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@rhettinger rhettinger rhettinger left review comments

Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json.load() can raise UnicodeDecodeError, but this is not documented
6 participants
@srinivasreddy @erlend-aasland @cjw296 @methane @rhettinger @serhiy-storchaka