Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100673: Removed erroneous note in the get_type_hints docs #100701

Merged
merged 1 commit into from
Jan 7, 2023
Merged

gh-100673: Removed erroneous note in the get_type_hints docs #100701

merged 1 commit into from
Jan 7, 2023

Conversation

FrozenBob
Copy link
Contributor

@FrozenBob FrozenBob commented Jan 3, 2023 •
edited by bedevere-bot
Loading

typing.get_type_hints still includes base class type hints, contrary to a note in the docs claiming this was changed in Python 3.10. The note was a mistake. This PR removes the incorrect note.

@FrozenBob
Removed erroneous note in the get_type_hints docs
6091ccb 
typing.get_type_hints still includes base class type hints.
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 3, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot mentioned this pull request Jan 3, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 3, 2023
hauntsaninja
hauntsaninja approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! cc @JelleZijlstra @sobolevn as reviewer of #99990

@hauntsaninja hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 3, 2023
AlexWaygood
AlexWaygood approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. I confirmed that, despite the behaviour of __annotations__ changing between 3.9 and 3.10, there was no behaviour change to get_type_hints between 3.9 and 3.10. (Cc. @MonadChains, as the author of #99990, and @sobolevn, who suggested adding the note to the get_type_hints docs.)

@AlexWaygood AlexWaygood merged commit deaf090 into python:main Jan 7, 2023
@miss-islington
Copy link
Contributor

Thanks @FrozenBob for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @FrozenBob and @AlexWaygood, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker deaf090699a7312cccb0637409f44de3f382389b 3.10

@bedevere-bot
Copy link

GH-100823 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2023
@FrozenBob @miss-islington
pythongh-100673: Removed erroneous note in the get_type_hints docs (p…
8ebba7d 
…ythonGH-100701)

Removed erroneous note in the get_type_hints docs

typing.get_type_hints still includes base class type hints.
(cherry picked from commit deaf090)

Co-authored-by: FrozenBob <[email protected]>
miss-islington added a commit that referenced this pull request Jan 7, 2023
@miss-islington @FrozenBob
gh-100673: Removed erroneous note in the get_type_hints docs (GH-100701)
a3e2407 
Removed erroneous note in the get_type_hints docs

typing.get_type_hints still includes base class type hints.
(cherry picked from commit deaf090)

Co-authored-by: FrozenBob <[email protected]>
@sobolevn
Copy link
Member

sobolevn commented Jan 7, 2023

Yeah, I still think that adding a note about __annotations__ is worth it, but just not about get_type_hints() this time :)

AlexWaygood pushed a commit to AlexWaygood/cpython that referenced this pull request Jan 7, 2023
@FrozenBob @AlexWaygood
pythongh-100673: Removed erroneous note in the get_type_hints docs (p…
ffa7765 
…ython#100701)

Removed erroneous note in the get_type_hints docs

typing.get_type_hints still includes base class type hints.

(cherry picked from commit deaf090)
@bedevere-bot
Copy link

GH-100826 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 7, 2023
miss-islington pushed a commit that referenced this pull request Jan 7, 2023
@AlexWaygood
[3.10] gh-100673: Removed erroneous note in the get_type_hints docs (#…
67e52e5 
…100701) (GH-100826)

Removed erroneous note in the get_type_hints docs

typing.get_type_hints still includes base class type hints.

(cherry picked from commit deaf090)

Automerge-Triggered-By: GH:AlexWaygood
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

@AlexWaygood AlexWaygood

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FrozenBob @miss-islington @bedevere-bot @sobolevn @hauntsaninja @AlexWaygood @JelleZijlstra