Improved connecting discontiguous corners #8659
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8616
#8620 was flawed, primarily because I didn't notice when updating the test image that the corners were no longer connected. Searching back through Pillow versions though, I don't actually think this ever worked as intended, and this was obscured by
assert_image_similar_tofile(img, expected, 1)
.So this PR serves as a rethinking of #5980, and changes to
assert_image_equal_tofile(img, expected)
to ensure that the result is actually correct.Here is how discontiguous corners are now connected to the rest of the polygon.