Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type checking in tests #8618

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

radarhere
Copy link
Member

This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.

In our test suite, this PR

  • asserts that a tuple is returned by getpixel(), rather than float or None, before index access is used

Pillow/src/PIL/Image.py

Lines 1680 to 1682 in 0e3f51d

def getpixel(
self, xy: tuple[int, int] | list[int]
) -> float | tuple[int, ...] | None:

  • asserts that load() does not return None before pixel access is used

def load(self) -> core.PixelAccess | None:

  • assert that palette is not None before trying to access one of its properties

self.palette: ImagePalette.ImagePalette | None = None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant