Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive dir from filename if root is the same in winbuild #8567

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Derive dir from filename if root is the same in winbuild #8567

merged 2 commits into from
Dec 17, 2024

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Nov 25, 2024 •
edited
Loading

Pillow/winbuild/build_prepare.py

Lines 134 to 135 in 4304414

"filename": f"libjpeg-turbo-{V['JPEGTURBO']}.tar.gz",
"dir": f"libjpeg-turbo-{V['JPEGTURBO']}",

It would seem like the "dir" could be derived from the "filename", simply by removing the file extension.

@hugovk hugovk merged commit 76919ad into python-pillow:main Dec 17, 2024
68 checks passed
@radarhere radarhere deleted the winbuild branch December 17, 2024 21:50
@radarhere radarhere mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

Assignees
No one assigned
Labels
Cleanup Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radarhere @hugovk