Ensure pyproject.toml accepts UTF-8 in maintainers
#3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Nov 10, 2022
| {name = "Brett Cannon", email = "[email protected]"} | ||
| {name = "Brett Cannon", email = "[email protected]"}, | ||
| {name = "John X. Ãørçeč", email = "[email protected]"}, | ||
| {name = "Γαμα קּ 東", email = "[email protected]"}, |
There was a problem hiding this comment.
I wonder if it'd handle IDNs as well. I'd add a test case for that too.
There was a problem hiding this comment.
@abravalheri turned out that the international emails aren't supported in the stdlib, so I thought it'd be reasonable to document that as an xfailing test case: #3670.
There was a problem hiding this comment.
Thank you very much @webknjaz
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes
Pull Request Checklist
changelog.d/.(See documentation for details)