Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config for the issue template chooser #7630

Merged
merged 5 commits into from
Jan 27, 2020

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz requested a review from pradyunsg January 21, 2020 15:55
@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Jan 22, 2020
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on a separate repository and these end up appended to the current set of configured issue templates, which is good. 👍

.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
url: https://discuss.python.org/c/packaging
about: Please ask typical Q&A here.
- name: 🔐 Security Policy
url: https://pypi.org/security/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the guidance for reporting PyPI/Warehouse security issues will be the same as for pip, at least because we haven't OK'd using that email distribution list for pip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I probably copy-pasted this when merging things from a few other configs that I contributed in different projects... So this should be removed for now.

But for the future, it'd be a good idea to formalize some security issues reporting guide and put it @ https://github.com/pypa/pip/security/policy and probably re-add this section here, plus docs. In a separate PR/discussion, of course.

cc @pradyunsg ^

.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@webknjaz webknjaz force-pushed the misc/gh-repo-config-issue-templates branch from 06a3c43 to ea17da2 Compare January 26, 2020 02:54
@webknjaz
Copy link
Member Author

I checked on a separate repository and these end up appended to the current set of configured issue templates, which is good. 👍

Also, I've posted references to a few other repos where I contributed similar configs in the comments above. So people don't really have to "deploy" the thing in forks to see how it works :)

@webknjaz webknjaz requested a review from chrahunt January 26, 2020 02:57
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. :)

@pradyunsg pradyunsg merged commit e9f4612 into pypa:master Jan 27, 2020
@pradyunsg
Copy link
Member

Me likey. :)

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants