Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable astroid for pylint CI check #1869

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Use stable astroid for pylint CI check #1869

merged 1 commit into from
Nov 14, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 14, 2022 •
edited
Loading

Description

At the moment, we use pip install -e . for the pylint CI check. That only works as long as there aren't any breaking changes.

Instead we should probably just use the latest released version which usually is the one the pinned pylint version ships with.

Required for #1867

@cdce8p cdce8p added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Nov 14, 2022
@cdce8p cdce8p added this to the 2.13.0 milestone Nov 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3462975278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.288%
Totals Coverage Status
Change from base Build 3454953543: 0.0%
Covered Lines: 9872
Relevant Lines: 10697
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thank you.

@Pierre-Sassoulas Pierre-Sassoulas merged commit e58aa09 into pylint-dev:main Nov 14, 2022
@cdce8p cdce8p deleted the ci-pylint branch November 14, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @coveralls @Pierre-Sassoulas