Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive optional plugin won't run #218

Closed
derrickb opened this issue Feb 9, 2017 · 5 comments
Closed

Inactive optional plugin won't run #218

derrickb opened this issue Feb 9, 2017 · 5 comments
Labels

Comments

@derrickb
Copy link

derrickb commented Feb 9, 2017

This could be related to a similar issue I filed on pyblish-lite: pyblish/pyblish-lite#90

I have an optional Validator, the first in the list, that I want to be off by default as it could take a long time to complete for larger scenes.

I have these properties on the plugin:

optional = True
active = False

If I attempt to run it either by itself or with the other plugins disabled, it doesn't get applied:
image
image

However if I change "active" to "True", then it does work:
image

@mottosso
Copy link
Member

Thanks for the detailed report @derrickb.

This looks to be some problem with the defaulting of the visual toggle in the GUI. active is the value the toggle is manipulating, and optional is what enables the user to manipulate it. By the looks of it, the toggle isn't getting the initial value of active as it is being loaded into the GUI.

Having a look at this as soon as possible.

@mottosso
Copy link
Member

Which version are you on?

>>> import pyblish_qml
>>> print(pyblish_qml.__version__)
0.7.1

@mottosso mottosso added the bug label Feb 11, 2017
@derrickb
Copy link
Author

0.7.1

@mottosso mottosso mentioned this issue Feb 15, 2017
mottosso added a commit that referenced this issue Feb 15, 2017
@mottosso
Copy link
Member

This has now been fixed in 0.8.1

For completeness and future self, the issue was that the Pyblish Iterator is using the active flag as a means of determining whether or not to process a plug-in, but QML did not update this variable. Since QML runs remotely, it proved tricky to try and modify this member and so instead I implemented a slimmed down version of the iterator specifically for QML.

For now, it's an ok solution, but it does defeat the initial purpose of a common iterator. Namely that if behaviour changes I'll now need to update both base and qml separately.

@mottosso
Copy link
Member

This should also re-enable the use of instance.data["publish"] = False for defaulting the toggled status of instances.

BigRoy added a commit to BigRoy/pyblish-qml that referenced this issue Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants