Changed logic in summary_frame for feature names #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng tests. Fixed a small bug in LinearModelFinalCateEstimatorDiscreteMixin where we werenot checking in intercept_ whether an intercept was fitted and raising an Attribute error if so. This lead to a weird error being raised because we were trying to reshape an integer.
kbattocchi
approved these changes
Nov 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed logic of feature names in summary_frame and added corresponding tests. Fixed a small bug in LinearModelFinalCateEstimatorDiscreteMixin where we werenot checking in intercept_ whether an intercept was fitted and raising an Attribute error if so. This lead to a weird error being raised because we were trying to reshape an integer.
Addressing #303