🛠 fix: Adapter overwrite passed-in retry #6395
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the API reference of
max_retries
ofrequests.adapters.HTTPAdapter
A widely used example can be found in this StackOverflow answer and is also under review in #6258.
However, the current source code does not really accept the passed-in
Retry
instance. Instead, it will silently discard and replace it with the defaultRetry
instance.This 2-line fix intends to fix the bug and restore its behavior to expect.