-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Oneof in proto files #362
Conversation
Also included a template to generate markdown from grpc proto spec Signed-off-by: Luis Pabón <[email protected]>
If this is a more up-to-date protokit compatible 1.1.0 compatible solution to fix the issue #333 I personally would love to see I raised PR #336 for this problem back in January, and I have been awaiting feedback ever since. I have changed jobs in the last six months, and would no longer have time to commit to making further updates in Go to move my own PR forward, so assuming you are more active in the area I would like to see this effort move to a successful conclusion. Does this also create a |
@pseudomuto anything blocking this from getting merged? Is it not compatible anymore with the latest version? |
Any update? |
Yes, please merge this one |
@pseudomuto could this be merged & released? |
Can we please get this merged @pseudomuto. Anything I can do to help? |
Pinging @pseudomuto again. Anything I/we can do to help? |
At a glance this LGTM 👍 At this point it'll need a rebase |
Any chance you're able to do so @pseudomuto / @lpabon. Otherwise I'll take a crack at it :) |
Submitted #436 to rebase this PR against current master. |
Hey guys! Just noticed this 4 years later now that I'm back on this again 😄 . Thank you so much for merging! |
Also included a template to generate markdown from grpc proto spec
Signed-off-by: Luis Pabón [email protected]