Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Oneof in proto files #362

Closed
wants to merge 1 commit into from
Closed

Conversation

lpabon
Copy link
Contributor

@lpabon lpabon commented Jun 28, 2018

Also included a template to generate markdown from grpc proto spec

Signed-off-by: Luis Pabón [email protected]

Also included a template to generate markdown from grpc proto spec

Signed-off-by: Luis Pabón <[email protected]>
@jason-fox
Copy link

If this is a more up-to-date protokit compatible 1.1.0 compatible solution to fix the issue #333 I personally would love to see oneOf added.

I raised PR #336 for this problem back in January, and I have been awaiting feedback ever since. I have changed jobs in the last six months, and would no longer have time to commit to making further updates in Go to move my own PR forward, so assuming you are more active in the area I would like to see this effort move to a successful conclusion.

Does this also create a oneOf description from the comments as well as a flag? Do the templates need updating? Is there anything else you could amalgamate from my effort?

@Globegitter
Copy link

@pseudomuto anything blocking this from getting merged? Is it not compatible anymore with the latest version?

@nicolassleiman
Copy link

Any update?

@guiguan
Copy link

guiguan commented Apr 2, 2020

Yes, please merge this one

@nielsvaneck
Copy link

@pseudomuto could this be merged & released?

@ping-localhost
Copy link

Can we please get this merged @pseudomuto. Anything I can do to help?

@ping-localhost
Copy link

Pinging @pseudomuto again. Anything I/we can do to help?

@pseudomuto
Copy link
Owner

At a glance this LGTM 👍 At this point it'll need a rebase

@ping-localhost
Copy link

At a glance this LGTM 👍 At this point it'll need a rebase

Any chance you're able to do so @pseudomuto / @lpabon. Otherwise I'll take a crack at it :)

fhalim pushed a commit to fhalim/protoc-gen-doc that referenced this pull request Jan 12, 2021
@fhalim
Copy link

fhalim commented Jan 12, 2021

Submitted #436 to rebase this PR against current master.

@lpabon
Copy link
Contributor Author

lpabon commented Aug 13, 2022

Hey guys! Just noticed this 4 years later now that I'm back on this again 😄 . Thank you so much for merging!

@lpabon lpabon closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants