Track finalized block root index and filter in blocks by range #3873
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3873 +/- ##
=======================================
Coverage 59.69% 59.69%
=======================================
Files 191 191
Lines 12177 12177
=======================================
Hits 7269 7269
Misses 3913 3913
Partials 995 995 |
|
I want to handle the case where the index is being built, but the process is interrupted. This could lead to an invalid / incomplete index. |
validator/BUILD.bazel
Outdated
| @@ -38,7 +38,7 @@ go_image( | |||
| goarch = "amd64", | |||
| goos = "linux", | |||
| importpath = "github.com/prysmaticlabs/prysm/validator", | |||
| pure = "on", | |||
| pure = "off", | |||
validator/BUILD.bazel
Outdated
| @@ -77,7 +77,7 @@ docker_push( | |||
| go_binary( | |||
| name = "validator", | |||
| embed = [":go_default_library"], | |||
| pure = "on", # Enabled unless there is a valid reason to include cgo dep. | |||
| pure = "off", # Enabled unless there is a valid reason to include cgo dep. | |||
There was a problem hiding this comment.
oops, will revert these
|
|
||
| container := &dbpb.FinalizedBlockRootContainer{ | ||
| ParentRoot: block.ParentRoot, | ||
| ChildRoot: previousRoot, |
There was a problem hiding this comment.
The first time the walk is performed , previousRoot will be an empty byte slice
There was a problem hiding this comment.
That is expected, there is no finalized child root yet. We just learned of a new finalized block and this is the highest finalized block to exist so far.
| // index bucket or genesis block root. | ||
| var walk = func() error { | ||
| for { | ||
| if bytes.Equal(root, genesisRoot) { |
There was a problem hiding this comment.
this walks all the way back to genesis each time we updated the finalized checkpoint, shouldn't it only walk back to the previous finalized checkpoint.
There was a problem hiding this comment.
It does, see line 67
| traceutil.AnnotateError(span, err) | ||
| return err | ||
| } | ||
| return bkt.Put(block.ParentRoot, enc) |
There was a problem hiding this comment.
ah sorry just saw this, its good then in that case
| featureconfig.Init(fc) | ||
| } | ||
|
|
||
| func TestStore_IsFinalizedBlock(t *testing.T) { |
There was a problem hiding this comment.
Is it possible to cover a few more cases ? ex: Across multiple epochs, with skipped slots at epoch boundaries,etc
There was a problem hiding this comment.
Hmmm, I'll think about overnight. There isn't any different code path for mulitple epochs with skipped slots. Epoch boundries aren't relevant here. As long as the finalized chain is a chain then this should work.
…d_block_root_index
…d_block_root_index
prestonvanloon
dismissed stale reviews from nisdas and terencechain
via
7397696
Resolves #3858.
Resolves #3819.
Resolves #3848.
This PR keeps track of finalized block roots in the database. This index can then be queried to ensure that the block is a finalized block. When serving blocks at RPC, the beacon chain node will query the index to filter non-finalized blocks.