add warning notes for cc|py_proto_library rules. #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To mention that the interface may change or be removed when bazel has support it natively.
|
Is there any kind of visibility rule we can add to restrict who can import this protobuf.bzl file? |
|
Not that I'm aware of. As some other projects also need the support, instead of writing their own, I guess it makes sense to have something temporary in the protobuf package before bazel is ready. |
|
LGTM |
liujisi
added a commit
that referenced
this pull request
Nov 2, 2015
add warning notes for cc|py_proto_library rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mention that the interface may change or be removed when bazel has
support it natively.