Support Info.plist on macOS and provide sample configuration files #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an updated launcher that supports getting JVM options from the bundle's Info.plist file, for backward compatibility with previous versions of Protégé.
Provide a sample conf/jvm.conf file containing a (commented) memory setting, to help users figure out how to change such settings. Likewise for the Protege.l4j.ini file that is specific to the Windows version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the macOS launcher so that it supports reading JVM options from the
Info.plistfile inside the application bundle, for backward compatibility with previous versions of Protégé.It also fills the
Protege.l4j.inifile (used to set the JVM options on Windows) with a commented line showing how to set the maximal heap size value (-Xmxoption), and provides a defaultconf/jvm.conffile for the Linux, MacOS, and platform-independent versions, containing a similar commented setting.