Fix build on RISCV #325
Merged
Fix build on RISCV #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR prometheus#318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on GOARCH=riscv{,64}, leading to a build/test failure: ./cpuinfo.go:71:9: undefined: parseCPUInfo ./cpuinfo_test.go:222:2: undefined: parseCPUInfo Signed-off-by: Tobias Klauser <[email protected]>
|
Ping, could this PR please be merged by someone with write access to the repo? Thanks! |
|
Thanks, I just hit this issues with version 0.1.3. |
|
@discordianfish, @SuperQ would it be possible to tag a new release with this PR included? Currently, the latest release https://github.com/prometheus/procfs/releases/tag/v0.2.0 is broken on |
zhsj
added a commit
to zhsj/client_golang
that referenced
this pull request
Jan 22, 2021
This picks up prometheus/procfs#325 Signed-off-by: Shengjing Zhu <[email protected]>
Cori1109
added a commit
to Cori1109/client_golang
that referenced
this pull request
Jan 9, 2023
This picks up prometheus/procfs#325 Signed-off-by: Shengjing Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #318 forgot to wire
parseCPUInfotoparseCPUInfoRISCVonGOARCH=riscv{,64}, leading to a build/test failure:/cc @discordianfish @SuperQ