Don't add unnecessary bookmark routes #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
constrain-bookmark-routes
branch
from
e08d385 to
ecb0f70
Compare
jcoyne
added a commit
to sul-dlss/earthworks
that referenced
this pull request
Sep 9, 2024
Bots were hitting the show route, which is not normally used. See projectblacklight/blacklight#3318
jcoyne
added a commit
to sul-dlss/earthworks
that referenced
this pull request
Sep 9, 2024
Bots were hitting the show route, which is not normally used. See projectblacklight/blacklight#3318
jcoyne
force-pushed
the
constrain-bookmark-routes
branch
from
ecb0f70 to
9efa771
Compare
jcoyne
force-pushed
the
constrain-bookmark-routes
branch
from
9efa771 to
40e8cf8
Compare
|
FWIW It looks like this would remove :show, :edit, and :new routes. |
tampakis
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Show" route is not necessary.