Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker compose usage #3254

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix docker compose usage #3254

merged 1 commit into from
Aug 6, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Aug 5, 2024

docker-compose has been replaced by docker compose (no dash).

docker-compose has been replaced by docker compose (no dash).
@jcoyne jcoyne changed the title Fix docker compose useage Fix docker compose usage Aug 5, 2024
@@ -7,7 +7,7 @@ services:
- ALPINE_RUBY_VERSION
# mounting . is causing seg-fault on macosx
#volumes:
#- .:/app
#- .:/app
depends_on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're moving to the newer conventions, they changed the recommended filename from "docker-compose" to just "compose"

https://docs.docker.com/compose/gettingstarted/#step-2-define-services-in-a-compose-file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not about conventions, but that they have completely removed docker-compose from this image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #3256 to track this suggestion.

@corylown corylown merged commit 05a3b9b into main Aug 6, 2024
12 checks passed
@corylown corylown deleted the docker-compose branch August 6, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants