-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve "Adding bookmark without bookmark counter raises an error" #3215
Resolve "Adding bookmark without bookmark counter raises an error" #3215
Conversation
@mamrey thank you. |
There was a rubocop issue that should be resolved now :) |
We are very interested in getting this fix merged and released so we can update our new Catalog to the newest version of blacklight. Could a maintainer approve the workflow for this MR? I am happy to become a maintainer if that would be helpful! |
Can this be rebased on main? I believe the problem with Ruby 3.2 builds is resolved there. |
Amrey is away on vacation and I don't have access to his fork. He's back on Monday, but if there's another way I could do it, I am happy to. |
@cgalarza you should be able to |
…it_from_raising_error_when_bookmark_counter_is_not_rendered
I ran the pipeline in my local fork and there's still an error. I'll have to look at it tomorrow. |
@jcoyne I am wondering if you have any advice on how to fix this error. It seems that capybara is not finding the 'Bookmarks' link because of the badge that's included in the link. The test works if I change the problematic line to:
The test also passes if I add the |
…it_from_raising_error_when_bookmark_counter_is_not_rendered
@mamrey @cgalarza I've been having a bit of trouble in the BL codebase recently and It keeps coming back to the test from this PR. I'm especially confused about the stub for
When that method on the CatalogController instance is |
I removed this test in #3245 to get the build working. |
Thank you for working on this. Yes, the test depends on the bookmark control not being rendered. The initial spec attempted to achieve this by adding the appropriate blacklight config. When looking into the build failures we found this test that we took inspiration from. I am okay with removing the test as you've done. |
@mamrey the difference is that in
|
Closes #3214