Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new method for getting secret_key_base #3124

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 18, 2024

@jrochkind
Copy link
Member

jrochkind commented Jan 18, 2024

The gemfile for blacklight main branch allows Rails down to 6.1

s.add_dependency "rails", '>= 6.1', '< 8'

I don't believe this method is available down that far? You may want to leave the conditional in, but add a branch for Rails.application.respond_to?(:secret_key_base), and maybe drop the one for Rails <= 5.1?

@jcoyne
Copy link
Member Author

jcoyne commented Jan 18, 2024

@jrochkind
Copy link
Member

Oh wacky, thanks for verifying! Why haven't we all been using this API all along, it was clearly right all along, and people were giving bad advice to use other things! Approved

@tpendragon tpendragon merged commit 7ff508d into main Jan 18, 2024
13 checks passed
@tpendragon tpendragon deleted the secret_key_base branch January 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants