Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox NAN #6

Closed
Rimander opened this issue Feb 5, 2019 · 9 comments
Closed

Firefox NAN #6

Rimander opened this issue Feb 5, 2019 · 9 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Rimander
Copy link

Rimander commented Feb 5, 2019

If use firefox.

  1. Open Calendar
  2. Change month
  3. Change to actual month
  4. Only view Nan Nan
@priyank-p priyank-p added bug Something isn't working help wanted Extra attention is needed labels Feb 5, 2019
@priyank-p priyank-p pinned this issue Feb 5, 2019
@priyank-p
Copy link
Owner

@Rimander can you post a screenshot, and provide the console logs? Also which firefox version are you using?

I am pretty sure simplepicker works fine on firefox, but will try out firefox today and see.

@limjinsun
Copy link

It happens to me too. in Chrome it works fine, but in FF it gives error when you select February.
screenshot 2019-02-13 at 01 44 57

@priyank-p
Copy link
Owner

OK, finally got time to debug this. I can reproduce this in firefox but not in chrome and only happens in February (I think just current month!). Don't have solid idea what it might be currently.

@priyank-p
Copy link
Owner

Done debugging, apparently new Date('13 Febuary 2019 12:00 PM') works in chrome and not in firefox. Looking into why it doesn't work...

@limjinsun
Copy link

reference this - https://stackoverflow.com/questions/3257460/new-date-is-working-in-chrome-but-not-firefox

@priyank-p
Copy link
Owner

@limjinsun Yep, thanks for the reference, I am planning to fix this by passing values as new Date(13, 2, 2019, 12, 00). I expect a fix soon followed by a release of new version on npm.

@limjinsun
Copy link

Thanks. I will look forward to it.

@priyank-p
Copy link
Owner

(Doing a release shortly! I fixed this issue in master)

priyank-p added a commit that referenced this issue Feb 13, 2019
@priyank-p
simplepicker: fix simplepicker breaking in firefox.
15dc103 
The issue was firefox had issues with parse date in format we used to pass in; actually chrome
was more flexible in handling date than the spec so we weren't following the correct spec hence
when someone changes the month in firefox the month and date displayed undefined and NaN.

Fixes: #6.

+
priyank-p added a commit that referenced this issue Feb 13, 2019
@priyank-p
simplepicker: fix simplepicker breaking in firefox.
5101269 
The issue was firefox had issues with parse date in format we used to pass in; actually chrome
was more flexible in handling date than the spec so we weren't following the correct spec hence
when someone changes the month in firefox the month and date displayed undefined and NaN.

Fixes: #6.
@priyank-p
Copy link
Owner

New release (v2.0.0) is out. Thanks @Rimander for the report and @limjinsun for all the help :)

@priyank-p priyank-p reopened this Feb 14, 2019
@priyank-p priyank-p unpinned this issue Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rimander @limjinsun @priyank-p