feat(driver-adapters): add "version()" support to QuaintQueryable #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5103 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
jacek-prisma
reviewed
Jan 6, 2025
| @@ -130,9 +130,25 @@ impl QuaintQueryable for JsBaseQueryable { | |||
| .await | |||
| } | |||
|
|
|||
| // Note: Needed by the Wasm Schema Engine only. | |||
| async fn version(&self) -> quaint::Result<Option<String>> { | |||
There was a problem hiding this comment.
I guess this call might be covered in some existing schema engine test, but I think it might be worth writing a basic explicit test case to ensure it works
There was a problem hiding this comment.
There isn't any infra to run Driver Adapters in Schema Engine tests right now, so this cannot be achieved currently. But in principle, I'd agree with you :)
jacek-prisma
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
version()implementation toQuaintQueryableinquery-engine/driver-adapters/src/queryable.rs.This is needed for
schema-engine-wasm.