Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate to GH Actions for release #4947

Merged
merged 57 commits into from
Jul 22, 2024
Merged

ci: Migrate to GH Actions for release #4947

merged 57 commits into from
Jul 22, 2024

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jul 9, 2024

Moves and finishes the work Joël did in https://github.com/prisma/prisma-engines-builds.

For release process, this gets rid of both buildkite and engineer.

In order to migrate all tests that were running on buildkite to GH Actions we had to into nested job per connector - otherwise, matrix exceeded 256 jobs limit.

Otherwise, it works more or less identical to how engineer did with a couple of exceptions:

  • Each OS gets built as a separate GH Actions job, results are uploaded as artifacts
  • Once all jobs for commit are finished, all artifacts get collected, uploaded to R2/S3 and verified in one step (engineer did it file by file).
  • It is possible to trigger interation version on non-integration branch by putting [integration] into the commit message.

@SevInf SevInf added this to the 5.17.0 milestone Jul 9, 2024
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ SevInf
❌ janpio
❌ Jolg42
You have signed the CLA already but the status is still pending? Let us recheck it.

@SevInf SevInf force-pushed the feat/gh-actions branch from cbff11a to 5de4da4 Compare July 10, 2024 08:15
@SevInf SevInf marked this pull request as ready for review July 10, 2024 08:17
@SevInf SevInf requested a review from a team as a code owner July 10, 2024 08:17
@SevInf SevInf requested review from Weakky and removed request for a team July 10, 2024 08:17
@SevInf SevInf marked this pull request as draft July 10, 2024 09:00
Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #4947 will not alter performance

Comparing feat/gh-actions (1249e88) with main (68bfdeb)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jul 10, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.056MiB 2.056MiB 0.000B
Postgres (gzip) 820.650KiB 820.650KiB 0.000B
Mysql 2.025MiB 2.025MiB 0.000B
Mysql (gzip) 808.058KiB 808.058KiB 0.000B
Sqlite 1.918MiB 1.918MiB 0.000B
Sqlite (gzip) 765.962KiB 765.961KiB 1.000B

@SevInf
Copy link
Contributor Author

SevInf commented Jul 11, 2024

/integration

@SevInf
Copy link
Contributor Author

SevInf commented Jul 11, 2024

Do not merge until Buildkite pipelines are disabled.

@SevInf SevInf force-pushed the feat/gh-actions branch 2 times, most recently from c608420 to f52f86e Compare July 17, 2024 12:26
@SevInf SevInf marked this pull request as ready for review July 17, 2024 12:56
@@ -900,7 +900,7 @@ mod many_count_rel {
// Nullable counts should be COALESCE'd to 0.
insta::assert_snapshot!(
run_query!(&runner, r#"{
findManyPost {
findManyPost(orderBy: {id: "asc"}) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without orderBy, this produced different order on Postgres 9

Copy link
Contributor

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉 cc @Jolg42

@SevInf SevInf force-pushed the feat/gh-actions branch 3 times, most recently from e582bc1 to 8ca8eea Compare July 19, 2024 11:03
@SevInf SevInf force-pushed the feat/gh-actions branch from 42aee8f to 1249e88 Compare July 22, 2024 13:05
@SevInf SevInf merged commit f66d888 into main Jul 22, 2024
313 of 314 checks passed
@SevInf SevInf deleted the feat/gh-actions branch July 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants