-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query-engine-wasm): vertical slice #4466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asm32-unknown-unknown compilation
…github.com:prisma/prisma-engines into feat/sql-query-connector-on-wasm32-unknown-unknown
…o feat/query-core-on-wasm32-unknown-unknown
…to unexpected case
* qe-wasm: Partially fix the test suite 1. Bash script for build did not abort on error, hence sed error on linux went unnoticed. 2. We don't actually need sed trickery sincce `wasm-pack` has a flag for changing binary name. 3. `tracing` feature does not actually work on WASM even partially: it panics on `Instant` invokation as soon as first span is created. Since we are running tests with all preview features enabled, that means that practically any test panics now. Disabled it again. A lot of tests are still failing on ThreadRng invocation and stacktrace is not really helpful, but I still think it's better if we get it working. * Update query-engine/query-engine-wasm/build.sh
SevInf
force-pushed
the
feat/query-engine-wasm32-unknown-unknown
branch
2 times, most recently
from
December 6, 2023 10:25
d7ad5d5
to
c7c8586
Compare
SevInf
requested review from
miguelff and
Weakky
and removed request for
a team
December 7, 2023 13:32
* Add a way to skip WASM tests * Temproary skip failing wasm tests on pg and neon * Skip timstamp test * Fix incorrect skips * Parse libsql.js.wasm version * Skip libsql wasm tests * Fix vitess version parsing * Skip wasm planetscale tests that are also skipped for napi * Rename jobs * Skip planetscale wasm tests * Fix some incorrect skips * And more fixes * Be careful when copy-pasting, please * One more fix * Fix null lists * Again: be careful when copy-pasting * Skip timestamp test on libsql and planetscale * Update .github/workflows/test-query-engine-driver-adapters.yml Co-authored-by: Joël Galeran <[email protected]> --------- Co-authored-by: Joël Galeran <[email protected]>
SevInf
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #4456, and contributes to https://github.com/prisma/team-orm/issues/549 (but it's not feature complete yet, so it doesn't close it).
This is the source code of
@prisma/query-engine-wasm
version0.0.6
0.0.18
.Closes #4121