chore: attempt Send/Sync-compatibility for JS transactions

prisma · Jul 29, 2024 · 3fabd89 · 3fabd89
1 parent 5e7db17
commit 3fabd89
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/query-engine/driver-adapters/src/proxy.rs b/query-engine/driver-adapters/src/proxy.rs
@@ -211,8 +211,8 @@ macro_rules! impl_send_sync_on_wasm {
 
 // Assume the proxy object will not be sent to service workers, we can unsafe impl Send + Sync.
 impl_send_sync_on_wasm!(TransactionProxy);
+impl_send_sync_on_wasm!(JsTransaction);
 impl_send_sync_on_wasm!(TransactionContextProxy);
+impl_send_sync_on_wasm!(JsTransactionContext);
 impl_send_sync_on_wasm!(DriverProxy);
 impl_send_sync_on_wasm!(CommonProxy);
-impl_send_sync_on_wasm!(JsTransaction);
-impl_send_sync_on_wasm!(JsTransactionContext);
diff --git a/query-engine/driver-adapters/src/transaction.rs b/query-engine/driver-adapters/src/transaction.rs
@@ -1,3 +1,5 @@
+use std::future::Future;
+
 use async_trait::async_trait;
 use metrics::decrement_gauge;
 use quaint::{
@@ -22,9 +24,13 @@ impl JsTransactionContext {
         Self { inner, tx_ctx_proxy }
     }
 
-    pub async fn start_transaction(&self) -> quaint::Result<Box<JsTransaction>> {
-        self.tx_ctx_proxy.start_transaction().await
+    pub fn start_transaction(&self) -> UnsafeFuture<impl Future<Output = quaint::Result<Box<JsTransaction>>> + '_> {
+        UnsafeFuture(self.tx_ctx_proxy.start_transaction())
     }
+
+    // pub async fn start_transaction(&self) -> quaint::Result<Box<JsTransaction>> {
+    //     self.tx_ctx_proxy.start_transaction().await
+    // }
 }
 
 #[async_trait]