Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): update range to include support for 19.x #5492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −8
Open

feat(react): update range to include support for 19.x #5492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d663b
feat(react): update range to include support for 19.x
joshblack Jan 6, 2025
59aa122
chore: add changeset
joshblack Jan 6, 2025
0266afb
Merge branch 'main' into feat/add-support-for-react-19
joshblack Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-boxes-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Update dependency range for React dependencies to include 19.x
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,11 @@
"yaml": "2.3.4"
},
"peerDependencies": {
"@types/react": "^18.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the chevron up doesn't include 19.x? I thought it would accept everything above that 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope 🙃 haha, at least as far as I understand. ^ would be only for minor or patch. An alternative operator could be >= which I think works exactly how you described

"@types/react-dom": "^18.0.0",
"@types/react": "18.x || 19.x",
"@types/react-dom": "18.x || 19.x",
"@types/styled-components": "^5.1.11",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react": "18.x || 19.x",
"react-dom": "18.x || 19.x",
"styled-components": "5.x"
},
"peerDependenciesMeta": {
Expand Down
Loading