fix: #16404 InputOtp: Unclear behavior when editing the filled component #17343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed line that prevents default input behaviour when the input's length has reached the maxLength, allowing only the "Backspace" button to work, in order to overwrite the value on each slot without having to delete it first.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@gianluigitrontini is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
gianluigitrontini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a line that previously prevented default input behavior when the input reached its maxLength. The restriction allowed only the "Backspace" button to function, requiring users to delete existing values before entering new ones. With this change, users can overwrite the value in each input slot directly, improving usability.
The change is very small and basically removes a line in the onKeyDown method. However if the change is too harsh, would love to learn more.
Defect Fixes
Allow editing inputotp when maxLength is reached, as stated in Issue #16404