Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toggle accordion on header text/icon click #15867

Closed
wants to merge 2 commits into from
Closed

fix: toggle accordion on header text/icon click #15867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c8539
enables toggle on accordion header text/icon click
navedqb Jun 20, 2024
492cb4e
Merge pull request #29 from navedqb/fix--15859
navedqb Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/app/components/accordion/accordion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,7 @@ export class AccordionTab implements AfterContentInit, OnDestroy {
}

toggle(event?: MouseEvent | KeyboardEvent) {
const target = event.target as HTMLElement;

if (this.disabled || !(target.tagName.toLowerCase() === 'a' && target.classList.contains('p-accordion-header-link'))) {
if (this.disabled) {
return false;
}

Expand Down
Loading