fixed #14807 #14252 #14603 - updated onToggleAll method to call onChange and onSelectAllChange #14826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the onToggleAll method always call onChange but added test to call onSelectAllChange only when all checked or all not checked refactored code to create getAllVisibleAndNonVisibleOptions method so that onToggleAll could reuse the functionality without cutting and pasting
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cetincakiroglu
added
the
Status: Pending Review
|
@cetincakiroglu @mehmetcetin01140 ??? Can this be merged please, it is crucial thing we use in our project? Thanks for understanding... |
|
Hi @rosenthalj Thanks a lot for the effort and support! |
cetincakiroglu
removed
the
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14807
Fix #14252
Fix #14603
I updated the onToggleAll method to call onChange.emit and onSelectAllChange.emit. Special logic was add to determine whether or not onSelectAllChange.emit should be called since a user could be filtering.
The first video shows the issue #14807 reproducer (which I created based on the steps provided in the issue) working after the fix. Note: the end of the video shows how the changes work when the user filters before toggling on and off
Fixed_Reproducer_14807.mov
The second video shows the issue #14252 reproducer working after the fix. Note: the end of the video also shows how the changes work when the user filters before toggling on and off
Fixed_Reproducer_14252.mov
The third video shows issue #14603 fixed, the PimeNG table filter-menu demo is fixed with this pull request
Fixed_14603.mov
This PR supersedes PR #14604