Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar overlay doesn't disappear in OnPush components. #8102

Closed
Hapcy opened this issue Aug 29, 2019 · 3 comments
Closed

Calendar overlay doesn't disappear in OnPush components. #8102

Hapcy opened this issue Aug 29, 2019 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Hapcy
Copy link

Hapcy commented Aug 29, 2019

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/github-zpt3km

Current behavior
Calendar overlay only disappears in ChangeDetectionStrategy.OnPush components, when another change detection runs because the markForCheck on calendar.ts:2077 is outside of zone and doesn't trigger change detection.

Expected behavior
Calendar should work like in ChangeDetectionStrategy.Default components.

Minimal reproduction of the problem with instructions
The provided stackblitz shows a calendar in a default and an onpush component side by side.

  • Angular version: >=8
  • PrimeNG version: 8.0.2
@yigitfindikli yigitfindikli self-assigned this Sep 2, 2019
@yigitfindikli yigitfindikli added this to the 8.0.3 milestone Sep 2, 2019
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 2, 2019
yigitfindikli added a commit that referenced this issue Sep 2, 2019
Fixed #8102 hide calendar overlay in onpush components
yigitfindikli added a commit that referenced this issue Sep 2, 2019
@yigitfindikli
Copy link
Contributor

Hi,
Thanks for contributing.
Best Regards.

@sebastienv
Copy link

Hi @yigitfindikli,
Shouldn't this same fix also be done on OverlayPanel ?
We currently facing a similar issue but with OverlayPanel and adding making the same fix make it works correctly.

JacobSiegle pushed a commit to JacobSiegle/primeng that referenced this issue Oct 2, 2019
JacobSiegle pushed a commit to JacobSiegle/primeng that referenced this issue Oct 2, 2019
@akisvolanis
Copy link

akisvolanis commented May 13, 2020

I have the same issue with OverlayPanel. [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants