Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The FocusTrap directive throws a JS exception on browsers #8075

Closed
meeCnu opened this issue Aug 22, 2019 · 4 comments
Closed

The FocusTrap directive throws a JS exception on browsers #8075

meeCnu opened this issue Aug 22, 2019 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@meeCnu
Copy link

meeCnu commented Aug 22, 2019

press tab on focustrap enabled child controls getting following error in Firefox browser

columnNumber: 215

fileName: "https://www.primefaces.org/primeng/22-es2015.b3f70586312af077c880.js"

lineNumber: 1

message: "event is not defined"

stack: "onkeydown@https://www.primefaces.org/primeng/22-es2015.b3f70586312af077c880.js:1:215\nk/<@https://www.primefaces.org/primeng/22-es2015.b3f70586312af077c880.js:1:1605\nhandleEvent@https://www.primefaces.org/primeng/main-es2015.e59da9ecf425701e6c44.js:1:101503\nhandleEvent@https://www.primefaces.org/primeng/main-es2015.e59da9ecf425701e6c44.js:1:122029\njr@https://www.primefaces.org/primeng/main-es2015.e59da9ecf425701e6c44.js:1:57523\nEo/<@https://www.primefaces.org/primeng/main-es2015.e59da9ecf425701e6c44.js:1:94890\nj/<@https://www.primefaces.org/primeng/main-es2015.e59da9ecf425701e6c44.js:1:211691\ninvokeTask@https://www.primefaces.org/primeng/polyfills-es2015.295561ab085ffc739b55.js:1:53671\nonInvokeTask@https://www.primefaces.org/primeng/main-es2015.e59da9ecf425701e6c44.js:1:79561\ninvokeTask@https://www.primefaces.org/primeng/polyfills-es2015.295561ab085ffc739b55.js:1:53584\nrunTask@https://www.primefaces.org/primeng/polyfills-es2015.295561ab085ffc739b55.js:1:49162\ninvokeTask@https://www.primefaces.org/primeng/polyfills-es2015.295561ab085ffc739b55.js:1:54676\nv@https://www.primefaces.org/primeng/polyfills-es2015.295561ab085ffc739b55.js:1:66658\ny@https://www.primefaces.org/primeng/polyfills-es2015.295561ab085ffc739b55.js:1:66902\n"

image

@meeCnu meeCnu changed the title "event is not defined" in FocusTrap "event is not defined" in FocusTrap - Firefox Browser Aug 22, 2019
@JacobSiegle
Copy link
Contributor

I don't see the same error. Can you specify which version of firefox you're using?

@meeCnu
Copy link
Author

meeCnu commented Aug 26, 2019

We are facing issue with
FireFox : 68.0.2 (32-bit)
OS: Windows 10

@mertsincan mertsincan changed the title "event is not defined" in FocusTrap - Firefox Browser The FocusTrap directive throws a JS exception on browsers Aug 28, 2019
@mertsincan mertsincan self-assigned this Aug 28, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 28, 2019
@mertsincan mertsincan added this to the 8.0.3 milestone Aug 28, 2019
@mertsincan
Copy link
Member

Fixed now!

@meeCnu
Copy link
Author

meeCnu commented Aug 29, 2019

Thanks for the Fix @mertsincan

JacobSiegle pushed a commit to JacobSiegle/primeng that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants