Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode: Missmatch between Code and Docs #17060

Closed
MrTob opened this issue Dec 16, 2024 · 0 comments · Fixed by #17064
Closed

Darkmode: Missmatch between Code and Docs #17060

MrTob opened this issue Dec 16, 2024 · 0 comments · Fixed by #17064
Assignees
@mehmetcetin01140
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
18.0.1

Comments

@MrTob
Copy link
Contributor

MrTob commented Dec 16, 2024

Describe the bug

The documentation describes that the dark mode can be set with the ‘darkModeSelector’ property. In the code, however, the ‘ThemeType’ type only has two valid properties: ‘preset’ and ‘options’ and not ‘darkModeSelector’ as in the documentation.
Docs
export type ThemeType = { preset?: any; options?: any; } | 'none' | boolean | undefined;

Environment

Win11 with VS Code

Reproducer

No response

Angular version

18.2.13

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@MrTob MrTob added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 16, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
mehmetcetin01140 added a commit that referenced this issue Dec 16, 2024
@mehmetcetin01140
Fixed #17060 | Darkmode: Missmatch between Code and Docs
ed28b17
mehmetcetin01140 added a commit that referenced this issue Dec 16, 2024
@mehmetcetin01140
Fixed #17060 | Darkmode: Missmatch between Code and Docs
02b9495
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Dec 16, 2024
Merged
mehmetcetin01140 added a commit that referenced this issue Dec 16, 2024
@mehmetcetin01140
Merge pull request #17064 from primefaces/issue-17060
1c856b8 
Fixed #17060 | Darkmode: Missmatch between Code and Docs
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 16, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
PrimeNG
Status: Done
Milestone
18.0.1
Development

Successfully merging a pull request may close this issue.

Fixed #17060 | Darkmode: Missmatch between Code and Docs primefaces/primeng
3 participants
@mertsincan @MrTob @mehmetcetin01140