Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18-rc.2 Component: ConfirmationDialog #16963

Closed
lengauermario opened this issue Dec 6, 2024 · 0 comments
Closed

v18-rc.2 Component: ConfirmationDialog #16963

lengauermario opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@lengauermario
Copy link

Describe the bug

I would like to apply a styleClass to the reject button of the dialog. The Dialog is opened with the ConfirmationService but the class p-button-secondary is not applied to the reject button.

The following code describes how i open the dialog.

 this.confirmationService.confirm({
                header: "Sind Sie sicher, dass Sie die Seite verlassen wollen?",
                message: "Sie haben nicht gespeicherte Änderungen.",
                acceptLabel: "Verlassen",
                rejectLabel: "Bleiben",
                rejectButtonStyleClass: "p-button-secondary", // todo: is not applied
                accept: () => resolve(true),
                reject: () => resolve(false),
            });

and in my app.component.html i have the target element

<p-confirmdialog />
<router-outlet />

the following template was generated
image

Environment

noticed while developing, on windows 11

Reproducer

https://stackblitz.com/edit/github-hmetwe?file=src%2Fapp%2Fapp.component.ts

Angular version

18.0.1

PrimeNG version

18.0.0-rc.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.5.1

Browser(s)

Chrome v. 131.0.6778.86

Steps to reproduce the behavior

  1. set property rejectButtonStyleClass
  2. open dialog
  3. see that the class is not applied

Expected behavior

No response

@lengauermario lengauermario added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 6, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 6, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 18.0.0.Final milestone Dec 6, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Dec 6, 2024
mehmetcetin01140 added a commit that referenced this issue Dec 6, 2024
Fixed #16963 | v18-rc.2 Component: ConfirmationDialog
@mehmetcetin01140 mehmetcetin01140 moved this to Done in PrimeNG Dec 6, 2024
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

2 participants