Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.0.0-rc.2: Stepper content duplicated when stepper is in Dialog #16936

Closed
mplgn opened this issue Dec 4, 2024 · 1 comment
Closed

18.0.0-rc.2: Stepper content duplicated when stepper is in Dialog #16936

mplgn opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mplgn
Copy link

mplgn commented Dec 4, 2024

Describe the bug

When a Stepper is inside of a Dialog, the content of each step panel is duplicated. This does not occur when the Stepper in on a "base" page. In the screenshot below, there is a Stepper on the base page and a Stepper in a Dialog. You can see that the Stepper in the Dialog has duplicated content. The Stepper code I'm using is from the PrimeNG 18 rc.2 demo.

Stackblitz link is provided below to demonstrate and reproduce this.

NOTE: this issue surfaced after upgrading from 18.0.0-beta.3 to 18.0.0-rc.2 (it was working correctly in beta.3).

image

Environment

Angular v18 + PrimeNG 18 rc.2
macOS Sequoia
Webstorm 2024.3

Reproducer

https://stackblitz.com/edit/stackblitz-starters-soyalt?file=src%2Fapp%2Fapp.component.html

Angular version

18.2.0

PrimeNG version

18.0.0-rc.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.17.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to the Stackblitz demo

  2. View the "correct" Stepper when the app loads

image
  1. Click the "Open Dialog" button

  2. View the broken Stepper when the dialog opens

image

Expected behavior

Stepper content should not be duplicated when embedded in a Dialog.

@mplgn mplgn added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 4, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@mertsincan mertsincan added this to the 18.0.0.Final milestone Dec 4, 2024
cetincakiroglu added a commit that referenced this issue Dec 5, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 5, 2024
@cetincakiroglu
Copy link
Contributor

fixed in 7757565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

4 participants