Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColumnFilter: Template names are wrong. #16180

Closed
wS2Zth opened this issue Aug 7, 2024 · 0 comments · Fixed by #16198 · 4 remaining pull requests
Closed

ColumnFilter: Template names are wrong. #16180

wS2Zth opened this issue Aug 7, 2024 · 0 comments · Fixed by #16198 · 4 remaining pull requests
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.8

Comments

@wS2Zth
Copy link
Contributor

wS2Zth commented Aug 7, 2024 •
edited
Loading

Describe the bug

The ColumnFilter template names on the Table API page and the implementation do not match.

In Table API Page;
https://primeng.org/table#api.columnfilter.templates

filterTemplate
headerTemplate
footerTemplate
filterIconTemplate
removeRuleIconTemplate
addRuleIconTemplate
clearFilterIconTemplate

In code;

case 'header':
case 'filter':
case 'footer':
case 'filtericon':
case 'clearfiltericon':
case 'removeruleicon':
case 'addruleicon':
default:

*When I pasted it as code, I couldn't get a proper view, so I wrote the names of the cases.

Environment

no need

Reproducer

No response

Angular version

no need

PrimeNG version

no need

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

no need

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@wS2Zth wS2Zth added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 7, 2024
wS2Zth added a commit to wS2Zth/primeng that referenced this issue Aug 7, 2024
@wS2Zth
primefaces#16180 is solved
9f84a68
@wS2Zth wS2Zth mentioned this issue Aug 7, 2024
Closed
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 8, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.8 milestone Aug 8, 2024
@cetincakiroglu cetincakiroglu added the Component: Documentation Issue or pull request is related to Documentation label Aug 8, 2024
@cetincakiroglu cetincakiroglu mentioned this issue Aug 8, 2024
Merged
cetincakiroglu added a commit that referenced this issue Aug 8, 2024
@cetincakiroglu
Merge pull request #16198 from primefaces/issue-16180
542abf4 
Fix template names, fixes #16180
This was referenced Aug 30, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Sep 20, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
mehmetcetin01140 added a commit that referenced this issue Nov 11, 2024
@mehmetcetin01140
Fixed #16180 | ColumnFilter: Template names are wrong.
ae60c7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.8
3 participants
@wS2Zth @cetincakiroglu @mehmetcetin01140