Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-accordion: click on p-accordion-header-text/icon doesn't toggle tab #15859

Closed
DbkMG opened this issue Jun 18, 2024 · 2 comments · Fixed by #15872
Closed

p-accordion: click on p-accordion-header-text/icon doesn't toggle tab #15859

DbkMG opened this issue Jun 18, 2024 · 2 comments · Fixed by #15872
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@DbkMG
Copy link

DbkMG commented Jun 18, 2024

Describe the bug

A click on the p-accordion-header-text doesn't toggle the tab.

Just tried the upgrade from primeng 17.14.1 and tests are now failing because of this issue.

this is reproducable in primeng-showcase

Environment

angular 17.3.10
primeng 17.18.1
tested in chrome & electron

Reproducer

No response

Angular version

17.3.10

PrimeNG version

17.18.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

  1. go to https://primeng.org/accordion -> Basic Example
  2. click on the header-text or icon of an accordion-tab (clicking on the tab-header itself works)
  3. -> the tab won't open or close

Expected behavior

an accordion-tab should also open/close by clicking on the header-text or icon. This worked in 17.14.1

@DbkMG DbkMG added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 18, 2024
@prx-lmo
Copy link
Contributor

prx-lmo commented Jun 20, 2024

workaround till this gets released:
downgrade to 17.17.0 and add in package.json

"overrides": {
    "primeng": {
      ".": "^17.17.0",
      "@angular/core": "^18.0.0",
      "@angular/common": "^18.0.0",
      "@angular/forms": "^18.0.0"
    }
  }

@rosenthalj
Copy link
Contributor

This issue is a duplicate of Issue #15851

PR #15867 fixes this Issue #15859 and Issue #15851.
PR #15867 reverts PR #15838 which broke the Accordion Header functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
3 participants