Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Dropdown TypeError: option.toLowerCase is not a function #14682

Closed
CyleClone opened this issue Feb 1, 2024 · 2 comments · Fixed by #14710
Closed

Component: Dropdown TypeError: option.toLowerCase is not a function #14682

CyleClone opened this issue Feb 1, 2024 · 2 comments · Fixed by #14710
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.6.0

Comments

@CyleClone
Copy link

Describe the bug

Same problem as in issue #14370:
Declaring a dropdown with a filter, but not specifying optionlabel="label" or filterBy="label" breaks the dropdown on filter.

Environment

Chrome, Mozilla

Reproducer

https://stackblitz.com/edit/github-3wjoqr?file=src%2Fapp%2Fapp.component.html

Angular version

17.x.x

PrimeNG version

17.x.x

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.x.x

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Default filter should reference to label as before, not undefined
@CyleClone CyleClone added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 1, 2024
@bartan34
Copy link

bartan34 commented Feb 1, 2024

I have the same problem. Event with 17.4.0.

@asithade
Copy link

asithade commented Feb 1, 2024

For me, when I have to add both optionLabel="label" and filterBy="label". Then because of that, I also have to add optionValue="value", if not it pastes the object instead of the value.

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 5, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.6.0 milestone Feb 5, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Feb 5, 2024
mehmetcetin01140 added a commit that referenced this issue Feb 5, 2024
@mehmetcetin01140
Fixed #14682 - Dropdown | TypeError: option.toLowerCase is not a func…
14e822b 
…tion
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Feb 5, 2024
Merged
cetincakiroglu added a commit that referenced this issue Feb 7, 2024
@cetincakiroglu
Merge pull request #14710 from primefaces/issue-14682
93668db 
Fixed #14682 - Dropdown | TypeError: option.toLowerCase is not a func…
@shdb2 shdb2 mentioned this issue Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.6.0
Development

Successfully merging a pull request may close this issue.

Fixed #14682 - Dropdown | TypeError: option.toLowerCase is not a func… primefaces/primeng
4 participants
@asithade @CyleClone @mehmetcetin01140 @bartan34