Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: required attribute not set in hidden input element #14322

Closed
mrkshx opened this issue Dec 11, 2023 · 0 comments · Fixed by #14506
Closed

Dropdown: required attribute not set in hidden input element #14322

mrkshx opened this issue Dec 11, 2023 · 0 comments · Fixed by #14506
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
17.3.2

Comments

@mrkshx
Copy link

mrkshx commented Dec 11, 2023

Describe the bug

When setting "required" attribute to Dropdown component, the screen reader doesn't inform the user that this dropdown is required as it is only added to p-dropdown element.

Environment

Primeng 16

also tested on Primeng 14 and 17

Reproducer

https://stackblitz.com/edit/2yfb3e?file=src%2Fapp%2Fdemo%2Fdropdown-basic-demo.html

Angular version

16.2.12

PrimeNG version

16.9.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

latest

Browser(s)

No response

Steps to reproduce the behavior

  • Add required attribute to p-dropdown
  • Open screen reader ( I tested with NVDA )
  • Tab focus the dropdown
  • Screen reader will not inform that dropdown is required

Expected behavior

required and aria-required attribute should be available for screen reader so that user gets informed that the dropdown element is required.
@mrkshx mrkshx added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2023
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 5, 2024
@cetincakiroglu cetincakiroglu added this to the 17.3.2 milestone Jan 8, 2024
mehmetcetin01140 added a commit that referenced this issue Jan 8, 2024
@mehmetcetin01140
Fixed #14322 - Dropdown | Required attribute not set in hidden input …
f2663a3 
…element
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jan 8, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jan 10, 2024
@cetincakiroglu
Merge pull request #14506 from primefaces/issue-14322
3bd1c8a 
Fixed #14322 - Dropdown | Required attribute not set in hidden input …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
17.3.2
Development

Successfully merging a pull request may close this issue.

Fixed #14322 - Dropdown | Required attribute not set in hidden input … primefaces/primeng
3 participants
@mrkshx @cetincakiroglu @mehmetcetin01140