Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload | File limit does not fire error #13129

Closed
cetincakiroglu opened this issue Jun 2, 2023 · 2 comments · Fixed by #13137
Closed

FileUpload | File limit does not fire error #13129

cetincakiroglu opened this issue Jun 2, 2023 · 2 comments · Fixed by #13137
Assignees
@gucal @cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.0.1

Comments

@cetincakiroglu
Copy link
Contributor

https://stackblitz.com/edit/j3bzrg?file=package.json,src%2Fapp%2Fdemo%2Ffile-upload-basic-demo.html
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 2, 2023
@cetincakiroglu cetincakiroglu added this to the 16.Future milestone Jun 2, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 2, 2023
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 2, 2023
@jlorellana684
Copy link

Hi, I would like to clarify, it's not the file limit itself. When fileLimit is set the error messages don't work.

@cetincakiroglu cetincakiroglu changed the title FileUpload | File limit does not work FileUpload | File limit does not fire error Jun 2, 2023
gucal added a commit that referenced this issue Jun 2, 2023
@gucal
Fix #13129 - FileUpload | File limit does not fire error
cae818b
@gucal gucal mentioned this issue Jun 2, 2023
Merged
@jlorellana684
Copy link

@gucal that doesn't solve the issue, try for example selecting an invalid file type and you won't get the error message.

@cetincakiroglu cetincakiroglu modified the milestones: 16.Future, 16.0.1 Jun 16, 2023
cetincakiroglu added a commit that referenced this issue Jun 16, 2023
@cetincakiroglu
Merge pull request #13137 from primefaces/issue-13129
4fe31d5 
Fix #13129 - FileUpload | File limit does not fire error
steve3d pushed a commit to steve3d/primeng that referenced this issue Aug 28, 2023
@gucal @steve3d
Fix primefaces#13129 - FileUpload | File limit does not fire error
d20b82f
mertsincan pushed a commit that referenced this issue Aug 29, 2023
@steve3d @volvachev
@cetincakiroglu @gucal @barais
feat: Add custom style class to p-table p-dataview p-treeview (#13205)
6069219 
* feat: Add custom style class to p-table/p-dataview/p-treeview

* fix(primeng/p-button): spinner style not working propely

Fixes #13148.

* Fixed #13183 - Make TreeNode generic

* Fix: Icon list visibility

* fix(primeng/p-menu): render html via `DomSanitizer`

Fixes #13128.

* fix(primeng/p-button): not working `loadingIcon` property, update loadingdoc example

Fixes #13098.

* fix: update angular version restriction

* fix(primeng/p-confirmDialog): not updated style in runtime

Fixes #13155.

* Fix #13129 - FileUpload | File limit does not fire error

* Fix #13201 - OverlayPanel: Incorrect position when inside of dialog in 16.0.0 (did not happen in rc2)

* Fix - Surface color list

* fix #13124

---------

Co-authored-by: Egor Volvachev <[email protected]>
Co-authored-by: Çetin <[email protected]>
Co-authored-by: gucal <[email protected]>
Co-authored-by: Olivier Barais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gucal gucal

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.0.1
Development

Successfully merging a pull request may close this issue.

Fix #13129 - FileUpload | File limit does not fire error primefaces/primeng
3 participants
@gucal @cetincakiroglu @jlorellana684