Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeNG component animation trigger warnings since updating Angular to 14.x #11617

Closed
nicholas-ochoa opened this issue Jun 13, 2022 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@nicholas-ochoa
Copy link
Contributor

Describe the bug

Since updating my project to Angular 14, I've seen a number of animation trigger warnings in the console when running my application. For example when using a p-panel component:

<p-panel [showHeader]="false">testing</p-panel>

I see the following in my console:

The animation trigger "panelContent" has built with the following warnings:
 - The following provided properties are not animatable: overflow
   (see: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_animated_properties)

Which seems to come from:

animations: [
trigger('panelContent', [
state('hidden', style({
height: '0',
overflow: 'hidden'
})),
state('void', style({
height: '{{height}}'
}), {params: {height: '0'}}),
state('visible', style({
height: '*'
})),
transition('visible <=> hidden', [style({ overflow: 'hidden'}), animate('{{transitionParams}}')]),
transition('void => hidden', animate('{{transitionParams}}')),
transition('void => visible', animate('{{transitionParams}}'))
])
],

Obviously not a huge issue, but reducing any additional noise in the console is always useful.

Environment

Angular 14.0.1
PrimeNG 13.4.1

Reproducer

No response

Angular version

14.0.1

PrimeNG version

13.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.15.0

Browser(s)

Chrome 102

Steps to reproduce the behavior

No response

Expected behavior

No response

@mountpoint
Copy link

It relates also to p-messages and p-accordionTab components.
I think there are much more components with this warning.

And yes, this warning appeared after updating to Angular 14

@yigitfindikli yigitfindikli self-assigned this Jun 28, 2022
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 28, 2022
@yigitfindikli yigitfindikli added this to the 14.0.0 milestone Jun 28, 2022
@yigitfindikli yigitfindikli modified the milestones: 14.0.0, 13.4.2 Jun 28, 2022
@craigashworth
Copy link

Also seeing it on rootItem and submenu
The animation trigger "rootItem" has built with the following warnings:

The animation trigger "submenu" has built with the following warnings:

@sthompson-celerity
Copy link

This should not be closed as it is still happening on accordionTab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

5 participants