Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bidder: TradPlus #5794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New Bidder: TradPlus #5794

wants to merge 2 commits into from

Conversation

tradplus
Copy link

@tradplus tradplus commented Jan 9, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit cd5df65
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/677f69b65524ec0008ad7389
😎 Deploy Preview https://deploy-preview-5794--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bretg
Copy link
Contributor

bretg commented Jan 9, 2025

Actually, looking at the code here, I think there's a problem. This documentation says zoneId is optional, but the json schema says it's required.

We need to talk about what zoneId actually is because it's part of the endpoint domain (https://{{ZoneID}}adx.tradplusad.com/{{AccountID}}/pserver) It's a strict rule in Prebid Server that publishers cannot be made to supply geographic information. It's ok if 'zoneId' is some kind of inventory identifier, but it's not ok if 'zone' is like 'Europe'. If so, zone needs to be optional and the bid adapter code needs to be updated to have a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants