Switch to node style listener to avoid using undici's (node dep) MessageEvent class #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In Node v22.3.0, Node's MessageEvent was replaced with undici's (nodejs/node#52370). MessageEvent is loaded lazily and requires globalThis and global during initialization. If a consumer of UVM mutates the global scope in bootCode before the MessageEvent gets loaded, it can lead to a less stable system.
Fix
Right now
bridge.js
relies onparentPort.addEventListener
for node environment to keep the interface consistent with web workers. TheaddEventListener
registers a listener that gets fired with MessageEvent's instance as an argument. This is now replaced withparentPort.on
, which registers a node-style listener, i.e., listener gets called directly withdata
received, and usage of MessageEvent class is avoided.worker.browser.js
is also updated to exposeon
method for consistency.