[Integration][PagerDuty] - Default Resources Enhancements #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Nov 25, 2024
| - Improved on the integration default resources for PagerDuty incidents kind | ||
| - Added blueprint and mapping for PagerDuty users | ||
| - Added logs to track the HTTP requests made to PagerDuty API | ||
| - Added a generic resync event handler to allow the integration to bring any valid resource from PagerDuty |
There was a problem hiding this comment.
which ones are expected to work? can we make sure we have a proper log on when we aren't able to sync data for the passed "generic" kind?
Comment on lines
+179
to
+183
| @ocean.on_resync() | ||
| async def on_global_resync(kind: str) -> ASYNC_GENERATOR_RESYNC_TYPE: | ||
|
|
||
| if kind in OBJECTS_WITH_SPECIAL_HANDLING: | ||
| logger.info(f"Kind {kind} has a special handling. Skipping...") |
There was a problem hiding this comment.
can you document expected resources that can be passed here? like users etc..
…://github.com/port-labs/ocean into PORT-11473-pagerduty-integration-enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Added enhancements to the integration default resources as well as the integration itself.
Why - Rethinking the way we map data from PagerDuty and the need to improve on the overall user experiences
How - By undertaking the following:
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.