Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equatable conformance to UncheckedSendable when value is equatable #1565

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

maxgoedjen
Copy link
Contributor

@maxgoedjen maxgoedjen commented Oct 25, 2022

This change makes it easier to have unchecked types (eg, Color, Image) in State objects.

  • swift test passed without issue.

@maxgoedjen maxgoedjen changed the title Add equatable conformance when value is equatable Add equatable conformance to UncheckedSendable when value is equatable Oct 25, 2022
@tgrapperon
Copy link
Contributor

tgrapperon commented Oct 25, 2022

It seems to me that Equatable is reasonable, given that one may also encounter this type in Action cases.
Isn't the compiler capable of inferring the implementation though?

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is definitely missing functionality. We'll merge as is and explore if we can simplify it per @tgrapperon's recommendation, as well as introduce other missing conditional conformances.

@maxgoedjen
Copy link
Contributor Author

Yep, right you are on the automatic synthesis @tgrapperon. Thanks for merging + extending 🙏 @stephencelis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants