Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adding labels to terms #934

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

koskila
Copy link
Contributor

@koskila koskila commented Oct 26, 2023

Why

This PR fixes the following issues:

What

The current implementation doesn't add labels to existing terms. There's an extension method called EnsureLabel that this PR changes to handle adding or updating new labels to terms.

Known issues

  • Working with term store is a little finicky here, too, so sometimes term store calls "just fail". Retry logic could be tweaked further to counter this.
  • I'm not sure how term set labels can be set - the entity does not have labels, and adding to Names doesn't seem to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants