Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localization for modern audience fields. #906

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Aug 9, 2023

Currently, when the "modern audience targeting" fields are added using PnP the display names are not localized.
When the fields are added using the SharePoint UI, however, they are.
This PR fixed that by adding the correct Resource-Ids as the display names.

@jansenbe jansenbe self-assigned this Aug 31, 2023
@jansenbe
Copy link
Contributor

Good improvement @nils-a , thanks for submitting this!

jansenbe added a commit that referenced this pull request Aug 31, 2023
@jansenbe jansenbe merged commit 8ed0268 into pnp:dev Aug 31, 2023
@nils-a nils-a deleted the l10n/modernAudience branch August 31, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants