Avoid retrying when the hostname cannot be found #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenbe
added a commit
that referenced
this pull request
Jun 23, 2022
KoenZomers
added a commit
to pnp/powershell
that referenced
this pull request
Jun 23, 2022
Adding PR entry for pnp/pnpframework#686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check that in case of a hostname not known SocketException, it doesn't blindly keep retrying. This can occur i.e. when you make a typo in the SPO hostname. It will silently and blindly keep trying to connect anyway. With this update, if the hostname doesn't exist, it will throw the exception up the stack to the caller gets notified of the problem.