Additional changes for fix #498

[fzbm]

The previously made changes for fix #498 were missing changes required for provisioning the header information.

Additional changes:

• Removed case for HeaderLayoutType.Standard in ExtractObjects, because default already handles this.
• Removed scope variable, because it is not used.
• Removed the Emphasis type reference from Enum.TryParse, because the out variable already specifies the type.
• ProvisionObjects now exits as soon as possible if no changes are required.
  • This also moves a possible server call for loading the web URL to a state, were this information would be required.
• Introduced some (single) blank lines to increase the readability of the code.

[PedroMordeP]

Hi
I was looking at this pull request and at the line 76 on ProvisionObjects
web.EnsureProperties(w => w.Url);
should be changed to
web.EnsureProperties(w => w.HeaderEmphasis, w => w.HeaderLayout, w => w.MegaMenuEnabled);

??

I was working on this issue and I also made same changes like you and then found this pull request.

[PedroMordeP]

If we don't do the web.EnsureProperties(w => w.HeaderEmphasis, w => w.HeaderLayout, w => w.MegaMenuEnabled);

I was getting this issue
The property or field 'HeaderLayout' has not been initialized. It has not been requested or the request has not been executed. It may need to be explicity request.

and the w.Url is not used :)

[fzbm]

@PedroMordeP You are right. I also stumbled up on this exception during previous tests. A temporary fix is to load the web or specifically the HeaderLayout property before applying the template. I changed this and created an additional commit. A test of the change worked just fine. I applied a template to a freshly created ClientContext and PnP changed the header layout type as expected.

Also loading HeaderEmphasis and MegaMenuEnabled is not required, because HeaderLayout is the only property which might not get set. The two other will definitely be set before accessing the value.

ExecutePostAsync requires the web URL. While the method ensures the property itself, loading it beforehand will save us an additional round trip to the server.